changes to remove unwanted calculations #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bxue-l2
reviewed
Jul 28, 2024
arbitrator/prover/src/kzgbn254.rs
Outdated
| @@ -51,7 +51,7 @@ pub fn prove_kzg_preimage_bn254( | |||
| let blob_commitment = kzg.commit(&blob_polynomial_evaluation_form)?; | |||
|
|
|||
| let mut commitment_bytes = Vec::new(); | |||
| blob_commitment.serialize_uncompressed(&mut commitment_bytes)?; | |||
| blob_commitment.serialize_uncompressed(&mut commitment_bytes)?; // why uncompressed ? | |||
There was a problem hiding this comment.
true, even kzg.rs used compressed I think, https://github.com/Layr-Labs/nitro/blob/eigenda-v3.0.3/arbitrator/prover/src/kzg.rs#L75C55-L75C65
anupsv
changed the base branch from
switch-srs-to-mainnet-srs
to
eigenda-v3.0.3
bxue-l2
approved these changes
Aug 7, 2024
added 7 commits
August 7, 2024 17:40
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing kzg calculations and removing unwanted things and aligning the remaining of the data with the data formatting.